I think Nightmare Moon's world would sadly not be very happy...
While her universe is comparatively safer to the rest of the war-torn timelines we saw in season 5, Luna's whole reason for becoming Nightmare Moon was due to ongoing neglect that caused her to spiral hard into envy, of which sadly manifested in a distorted ego and superiority complex. So long as she's like that, the poor mare is sadly in no state to nurture an entire nation since such a burden naturally comes with a fair amount self-sacrifice. Rather than loving them unconditionally and providing them their own chances to shine bright, Nightmare Moon will only love her subjects so long as she feels she is getting the love and admiration she deserves, which could have potentially disastrous outcomes if she, at any moment, feels that her subjects aren't admiring her enough or there is even the littlest of push-back against her, real or perceived. Even if her Equestria seemed relatively fine when we saw it, I can't imagine it lasting very long under her rule before it either fall apart because her subjects couldn't keep up with her unstable demands, or just plain fails to thrive due to the oppressive nature imposed on it.
As for the rest of the land, no doubt her eternal night would have some pretty serious consequences. Equestria would need an entirely new food and agriculture system for starters, and I can only imagine how cold it will get without the sun to help provide warmth. Not to mention the sheer number of health problems that would arise from the lack of the sun, since so crucial for good health, such as maintaining healthy sleep cycles, vitamin D production + calcium absorption, and release of serotonin and endorphins (Its why ppl have such a hard time sleeping and feeling good in the Winter). Plus, who knows what monsters could be running loose without harmony and all that jazz to normally keep them at bay! Those first few years would not be easy and would need a LOT of magic and improved technology to counteract it, and even then could still cause a good amount of problems in the long-term
To put it bluntly, Nightmare Moon's world would be one heck of a nightmare I'll show myself out